Correct locale extraction to exclude delims #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardera
approved these changes
Jun 28, 2022
|
Thanks! I think logging the locale information on startup is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subj
This PR corrects extraction of locale information
Originally code would include delimiter inside country code, encoding or modifier.
This PR intentionally excludes these delimiters now, making flutter-pi to initialize flutter locale information without them correctly
I also added printing of locale during startup, it would be helpful to identify it for user instead of debugging :)
P.s. This only affects applications that rely on system locale information (e.g. easy_localization which uses system locale as default)